Fix #2146: Make nested implicit function types work #2235
Conversation
|
@felixmulder It fails because it does not find dotty.tools.dotc.ParallelTesting. |
1. Propagate expected type when typing an implicit closure. This is necessary to recursively apply eta expansion in the case of nested implicit functions. 2. Generalize match pattern in shortcutImplicits. This is necessary to avoid a crash.
This is necessary so that we can typecheck the last 4 statements of i2146.scala.
It was not necessary to widen it, after all.
|
@odersky Thanks alot for addressing the bug! Judging from the output of type using[A, B] = implicit B => A
type and[A, B] = implicit B => A
def foo: Int using A and B = { ... }Maybe add some tests on partially eta-expanded implicits? Variant 1 - Outside-In (✔)def foo: implicit A => implicit B => Int = { implicit a: A => ... }Variant 2 - Inside-Out (✘)def foo: implicit A => implicit B => Int = { implicit b: B => ... }As I still know too little of the dotty compiler, I can't say much about how the code changes affect other existing functionality. You probably want to ask a second reviewer for that. |
|
Thanks for dotty-staging#2.
👍. But FWIW, more recursion in |
Fix problems related to implicit function types.
Propagate expected type when typing an implicit closure.
This is necessary to recursively apply eta expansion in the
case of nested implicit functions.
Recursively transform definitions and accesses in shortcurImplicits
Generalize normalize to handle implicit function types
Review by @b-studios?